Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic usage wrongly documented: datetime.date vs. datetime.datetime #690

Closed
damarvin opened this issue Nov 6, 2021 · 2 comments · Fixed by #701
Closed

Basic usage wrongly documented: datetime.date vs. datetime.datetime #690

damarvin opened this issue Nov 6, 2021 · 2 comments · Fixed by #701
Assignees

Comments

@damarvin
Copy link

damarvin commented Nov 6, 2021

In the lower part of https://workalendar.github.io/workalendar/basic.html example

>>> cal.add_working_days(datetime(2012, 12, 23, 14, 0, 39), 5)
datetime.datetime(2012, 12, 31)

the output is wrongly given, making the following keep_datetime=True option hardly understandable.
Actually the result is

datetime.date(2012, 12, 31)

which makes more sense here. ;-)

@brunobord brunobord self-assigned this Dec 9, 2021
@brunobord
Copy link
Member

indeed. Will fix this, thanks for the bug report.

@brunobord
Copy link
Member

The documentation bugfix has been included in the latest release of Workalendar, now available on PyPI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants