Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holidays generated do not reflect their indicated date #78

Closed
jaraco opened this issue May 9, 2014 · 2 comments
Closed

Holidays generated do not reflect their indicated date #78

jaraco opened this issue May 9, 2014 · 2 comments

Comments

@jaraco
Copy link
Contributor

jaraco commented May 9, 2014

When rendering a calendar, it would be useful for the calendar to reflect the indicated date for each holiday. For example, "New year" happens on "the first day in January" or "January 1st". That's pretty simple, but other holidays have a more complicated indication, such as "Martin Luther King, Jr. Day" which is indicated on the "3rd Monday in January". These indications are useful for someone reading the calendar to know what indicated that date.

@jaraco
Copy link
Contributor Author

jaraco commented May 9, 2014

For this issue and the prior two, I have an approach that I've used in a similar project which I find works much better for allowing a calendar to represent its holidays. I'll be putting together a pull request with a draft.

@jaraco
Copy link
Contributor Author

jaraco commented Sep 24, 2014

If you desire this feature, consider the calendra fork.

@jaraco jaraco closed this as completed Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant