Consider a Holiday class #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- extra : amend_source : e2b1f36319875798bf21deb3075deab65f9ea230
--HG-- extra : rebase_source : d0ec2a68e9565aaa015984de775b07df1d263189
…_HOLIDAYS to contain Holiday entries.
--HG-- extra : amend_source : f15d243f1146ebf29f8970f2e3159be9265df632
…vance dates reflected in each result.
…t for relativedelta addition)
…ame', similar to the original two-tuple. 'indication' and 'weekend_hint' are now optional arguments as are any additional keyword arguments used in construction.
--HG-- extra : amend_source : 8ecc724430c4ea14fdc35f99b014d23c2fff75d1
…ich the default is now defined in the Calendar class.
--HG-- extra : amend_source : f8b6166e815bd352874ac388f7450d4fec93df85
--HG-- extra : amend_source : 3cc9be7eb9bb69645bc3c17a987e4cd3cffeb577
jaraco
pushed a commit
that referenced
this pull request
Jan 2, 2018
* Merge ireland.py * Adding Ireland * Add Ireland tests * Add Ireland * Add Ireland * Ireland tests * Ireland changelog
jaraco
pushed a commit
that referenced
this pull request
Feb 10, 2024
fix: 2024 Chinese New Year's Eve issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of this Holiday class enables an individual calendar implementer to more accurately describe each holiday using a first-class object. These changes demonstrate how the use of such a class gives more flexibility about the definition of each holiday, including when it is observed.
As a result, this fixes (or provides a mechanism to fix) workalendar#76, workalendar#77, and workalendar#78.
As much as possible, these changes attempt to maintain backward compatibility, but it's plausible that some users will find the changes incompatible with their customizations.
All the tests pass (on Python 3 at least).
I'm not necessarily requesting that these changes be merged as-is, but I did want to collect these changes as a concrete proposal for consideration and discussion. Accepting changes like these would be essential for me to adopt workalendar for my application.
I look forward to your feedback.