Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.6 configuration in travis and tox. #211

Merged
merged 3 commits into from
Jun 12, 2017
Merged

Add Python 3.6 configuration in travis and tox. #211

merged 3 commits into from
Jun 12, 2017

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Jun 10, 2017 •
edited

Refs #210

  • Tests
  • Changelog amended with a mention describing your changes.

@brunobord
Copy link
Member

I think you're clear to squash, I'll merge it when I can

brunobord
brunobord reviewed Jun 10, 2017
View reviewed changes
CHANGELOG Outdated
@@ -4,7 +4,8 @@ CHANGELOG
master (unreleased)
-------------------

Nothing here yet.
- Run tests with Python3.6 in CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please refer to the issue number here?

@Natim
Copy link
Contributor Author

Natim commented Jun 11, 2017 •
edited

You should be able to use the Github button to merge and squash.
For some reason described here and there I am not fan of squashing because it removes the history of what happened and it makes people think that everything was right the first time which is not the case. The review process is important and being able to display that you took some time to make comments and that I added a new commits to take those comment into account and that it took us some time on both side is important to me.

@brunobord
Copy link
Member

I am not fan of squashing

/me shrugs
No strong opinion on this, don't worry, I'm still very excited that we're Python 3.6 ready!

@brunobord brunobord merged commit 1770208 into workalendar:master Jun 12, 2017
@Natim Natim deleted the python36 branch June 12, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord brunobord left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Natim @brunobord