Extended registry #280
Merged
Extended registry #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #257 FYI, I've transformed the `oceania.py` into a module, for more consistency.
I thought it was a bit sad that you had to give a `name` class property that was just for the sake of having a string to decribe the class. Describing the class means using a `docstring`. Now the `name` property is deducted from the docstring, and all the Europe classes along with the "core" United States one are aligned with a more Pythonic way: a class should always have a docstring.
brunobord
force-pushed
the
extended-registry
branch
from
4a79f8f
to
f8ad031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13, closes #96, closes #257
docs/directory