Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Barbados calendar with public holiday 2021 #647

Merged
merged 2 commits into from May 7, 2021

Conversation

ludsoft
Copy link

@ludsoft ludsoft commented Apr 30, 2021

refs #

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

Two new non computable holiday have been added plus two fixes for boxing day that behaves differently in barbados and the collision of Emancipation Day and Independence Day.

Here is the official source for the fixes: https://labour.gov.bb/library/library-publications/holidays/
And the official source for the annoncement of the two public holiday: https://gisbarbados.gov.bb/download/official-gazette-january-2-2021-part-a-no-1-package/ (page4)

@brunobord
Copy link
Member

oh cool! it looks like we need a hotfix release, even if it arrives a bit too late for the january extra-holidays :(
thanks for the patch!

Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more tests needed to make sure the Emancipation Day algorithm is correctly implemented.

@brunobord
Copy link
Member

In any case, if you need some help, do not hesitate to ping me :o)

@brunobord brunobord merged commit 2516caf into workalendar:master May 7, 2021
@brunobord
Copy link
Member

The 15.3.0 release has been published on PyPI with your changes. Happy upgrading!

@ludsoft
Copy link
Author

ludsoft commented May 10, 2021

Thanks a lot for the project and the quick turnaround. Have a great day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants