Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nigeria calendar #656

Merged
merged 2 commits into from Jul 12, 2021
Merged

Conversation

taiyeoguns
Copy link
Contributor

Add Nigeria calendar.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

@brunobord
Copy link
Member

Awesome contribution!!!

May I ask you, if you can, to rebase your branch against the latest master? there's a "conflict" due to the recent upstream changes in the Changelog.md file. Hopefully quite easy to solve. If you need any help about this, please, do not hesitate to ask.

Again: I'm very happy Nigeria would be added to Workalendar!

@taiyeoguns
Copy link
Contributor Author

Thanks @brunobord, it's been updated.

@brunobord brunobord merged commit f5cc63e into workalendar:master Jul 12, 2021
@brunobord
Copy link
Member

Nigeria is now added to the Workalendar library through the 15.4.0 Release.

Happy upgrading!

@taiyeoguns taiyeoguns deleted the nigeria-calendar branch July 13, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants