Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendar for Georgia (country) #687

Closed
wants to merge 7 commits into from
Closed

Conversation

atj01
Copy link
Contributor

@atj01 atj01 commented Oct 26, 2021

This PR is intended to add a new calendar for the country of Georgia.

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

@atj01 atj01 changed the title Georgia Add calendar for Georgia (country) Oct 26, 2021
@brunobord
Copy link
Member

hello!

same as for your Kazakhstan PR... just a few lines too long. No big deal, and your PR can be merged right after that.

@atj01
Copy link
Contributor Author

atj01 commented Dec 13, 2021

Hi @brunobord,

many thanks for looking into this PR! Sorry, I totally missed the flak8 tests.. I've checked the failing tests and I fixed the flake8 issues. Hopefully it will pass now all the tests.

@brunobord
Copy link
Member

same as for the Kazakhstan PR, I'll integrate this patch in a bigger "meta PR"

@brunobord
Copy link
Member

superseeded by #699

@brunobord brunobord closed this Jan 21, 2022
@brunobord
Copy link
Member

Georgia has been included in the latest release of Workalendar, now available on PyPI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants