Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendar for Kazakhstan #688

Closed
wants to merge 5 commits into from
Closed

Conversation

atj01
Copy link
Contributor

@atj01 atj01 commented Oct 28, 2021

This PR is intended to add a new calendar for the country of Kazakhstan.

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

@brunobord
Copy link
Member

your PR looks like it's working. Unfortunately, it didn't pass the flake8 checks.
https://github.com/workalendar/workalendar/runs/4475641623?check_suite_focus=true

Could you please fix these errors? (mostly "lines too long", due to comments — do not hesitate to put your comments above to save place)

You're almost there, don't despair! I'm eagerly waiting for your contribution to be ready!

@brunobord
Copy link
Member

There's also a Python error in the label assertions. You'll have to make sure that, for the iCal export, each label should be unique. You'll have to check that you don't have the same label twice, then.

@atj01
Copy link
Contributor Author

atj01 commented Dec 13, 2021

Hi @brunobord,

Thanks a lot for looking into this PR and your comments are greatly appreciated! I fixed the flake8 issues as well as the multiple labels / dates appearing in case the get_fixed_holidays() method is called multiple times. Sorry that was a stupid mistake in get_fixed_holidays().. I hope this will pass now. Thanks again for checking!

@brunobord
Copy link
Member

I'm so late with all the current PRs…
I'm going to take your contribution into account, but in a different way than the others! Stay tuned!

@brunobord
Copy link
Member

superseeded by #699

@brunobord brunobord closed this Jan 21, 2022
@brunobord
Copy link
Member

Kazakhstan has been included in the latest release of Workalendar, now available on PyPI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants