Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Calendar: added Tunisia #703

Closed
wants to merge 4 commits into from
Closed

Conversation

macharmi
Copy link
Contributor

@macharmi macharmi commented Jan 29, 2022

closes #702

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.
  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! It looks like your contribution is very interesting! You're very close from getting into the upstream code.

You may need to do a couple of things before I can merge Tunisia in workalendar:

  • You'll have to rebase your branch from master. If you need some help, please do not hesitate to ask.
  • You may also want to try to add a more recent year to the test suite. Why not 2022?

@macharmi macharmi requested a review from brunobord March 1, 2022 14:36
@brunobord brunobord mentioned this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tunisia
2 participants