Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coronation of His Majesty King Charles III Bank holiday in 2023 to the UK calendar. #727

Merged
merged 4 commits into from Jan 3, 2023

Conversation

mountinash789
Copy link
Contributor

GOV.UK Press release

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

@brunobord
Copy link
Member

could you please rebase your PR from the latest master branch? It has dropped support for Python 3.6, and added support for Python 3.10/3.11

(if you have any trouble rebasing, please tell me)

@mountinash789
Copy link
Contributor Author

@brunobord Happy New Year, I have rebased from master. Tests are failing because of the lack of support for 2023 in the Chinese calendar.

@brunobord
Copy link
Member

okay, great... and oops, not so great.
There's an ongoing PR here: #728 about China's 2023 holidays.

when it's merged you'll have to (unfortunately) re-rebase against the new master.
sorry about that.

@brunobord
Copy link
Member

now you can. :o)

@brunobord
Copy link
Member

ok, bear with me for a minute: I'm going to make a release, and then you'll be able to rebase from latest master.

@brunobord
Copy link
Member

okay, you're clear to rebase.

Again, sorry for the inconvenience.

@brunobord brunobord merged commit b131f2b into workalendar:master Jan 3, 2023
@uostimb uostimb mentioned this pull request Apr 4, 2023
@jaraco
Copy link
Contributor

jaraco commented Feb 29, 2024

I've merged this feature into the calendra project and released as v7.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants