Parse URL When Ensuring CORS for Direct Uploads #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `request.url` returns the full URL, with path included. This isn't valid for a CORS header, which needs just the scheme, host, and port if it's non-standard. Update the `DirectUpload.ensure_cors!` method to parse out those pieces of the URL and re-assemble it for the CORS header and ID. No changelog Fixes #19
|
Why does the port being "non-standard" matter? |
Because in a browser, |
bencrouse
approved these changes
Sep 12, 2019
bencrouse
deleted the
parse-url-when-ensuring-cors-for-direct-uploads
branch
mttdffy
added a commit
that referenced
this pull request
Sep 12, 2019
mttdffy
added a commit
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
request.urlreturns the full URL, with path included. This isn'tvalid for a CORS header, which needs just the scheme, host, and port if
it's non-standard. Update the
DirectUpload.ensure_cors!method toparse out those pieces of the URL and re-assemble it for the CORS
header and ID.
No changelog
Fixes #19