Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test only asserts product details for product system test #54

Merged
merged 1 commit into from Sep 13, 2019

Conversation

mttdffy
Copy link
Contributor

@mttdffy mttdffy commented Sep 11, 2019

fixes #42

I cannot confirm, but my suspicion is that recently viewed may be the culprit here. I've adjusted the test to only look at the product details specifically.

@bencrouse
Copy link
Contributor

Ok, I'm going to re-run the build a few times to try to verify before merging.

@bencrouse
Copy link
Contributor

Wow, apparently you can't re-run a successful build? What a world. Running one of the failed ones...

@bencrouse bencrouse merged commit 1053a70 into v3.4-stable Sep 13, 2019
@bencrouse bencrouse deleted the bugfix-42-system-test-failure branch September 13, 2019 14:08
@tubbo tubbo added this to the v3.4.16 milestone Sep 16, 2019
@meowsus meowsus added this to In progress in 09/17/19 Release via automation Sep 17, 2019
@meowsus meowsus moved this from In progress to Reviewer approved in 09/17/19 Release Sep 17, 2019
@meowsus meowsus moved this from Reviewer approved to Done in 09/17/19 Release Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants