Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move towards using react-query for account data lifecycles #215

Merged
merged 17 commits into from
Jul 15, 2022
Merged

Move towards using react-query for account data lifecycles #215

merged 17 commits into from
Jul 15, 2022

Conversation

SvenDowideit
Copy link
Member

@SvenDowideit SvenDowideit commented Jul 13, 2022 •
edited
Loading

there's some cache stuff in here too, but I won't use it for the programchanges getAccount cache yet - its useful for the getParsedAccount and token ata list tho

closes #206
closes #207

and probably #209

extra issues that can be done later:

@SvenDowideit
yes, I think this is less code :)
a07de79 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit SvenDowideit added this to the 0.4.0 milestone Jul 13, 2022
@SvenDowideit SvenDowideit self-assigned this Jul 13, 2022
@SvenDowideit
move the react-query query function to getAccountss.ts
f66eec1 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
WIP - i get a blank electron, no dev-tools, and no errors in the cons…
fc299c8 
…ole :(

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
WIP - i get a blank electron, no dev-tools, and no errors in the cons…
cd4414b 
…ole :(

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
why do I keep having to fix this?
53f88b4 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
and now it works - useQuery for tokenlinst
7714ccf 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
token metadata react-query
3dfa25e 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
use react-query for top level AccountView getParsedAccount request
1c842fc 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
how does it look when we have a useParsedAccount(net, pubKey) hook?
cf4d4ac 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit SvenDowideit mentioned this pull request Jul 13, 2022
Closed
@nathanleclaire nathanleclaire modified the milestones: 0.4.0, 0.5.0 Jul 13, 2022
@SvenDowideit SvenDowideit mentioned this pull request Jul 14, 2022
Closed
@SvenDowideit
Merge remote-tracking branch 'origin/main' into account-data-request-…
2b46c4d 
…lifecycle-and-cache
@SvenDowideit
invalidate the react-query cache on demand, and on mint - but ... it …
bf388df 
…needs a tiny delay :/

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
replace useInterval with useQuery - not perfect, but not spamming the…
19bdfb7 
… rpic endpoint either - for #207

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
linties
bf6780b 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit SvenDowideit modified the milestones: 0.5.0, 0.4.0 Jul 14, 2022
@SvenDowideit SvenDowideit changed the title [WIP] move towards using react-query for account data lifecycles Move towards using react-query for account data lifecycles Jul 14, 2022
@SvenDowideit
ok, weird fix, but letting the mint info retry seems to make the Mint…
9e4ca34 
… accordion work

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
sssshhhh those logs
d280ab0 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
sssshhhh those logs
3a6be15 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
noidea what changed this, remove
081a051 
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
Copy link
Member Author

@nathanleclaire please review and merge :)

this is a shed tonne faster to render, and is allowing me to sit watching ProgramChanges on mainnet-beta, viewing my real account in the AccountView.

its not perfect, because we don't get to batch getParsedAccount yet :) but fixing that is imo a future PR

(for eg 48Dactjx3zuJujtBHZ5cd2w3maKFFGsKhn1sXzU59VGK - https://explorer.solana.com/address/48Dactjx3zuJujtBHZ5cd2w3maKFFGsKhn1sXzU59VGK just got me kicked off - waited 2 minutes, and its back tho...)

This was referenced Jul 14, 2022
Closed
Open
@SvenDowideit SvenDowideit mentioned this pull request Jul 15, 2022
Merged
@SvenDowideit
Copy link
Member Author

need to start integration testing, merging

@SvenDowideit SvenDowideit merged commit 773b7ae into main Jul 15, 2022
@SvenDowideit SvenDowideit deleted the account-data-request-lifecycle-and-cache branch July 15, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanleclaire nathanleclaire Awaiting requested review from nathanleclaire

Assignees

@SvenDowideit SvenDowideit

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Error: IDL not found and unable to find account Loading AccountsView feels mushy
2 participants
@SvenDowideit @nathanleclaire