Pubkey validation added to WatchAccountPopover #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohh. It uses localstorage. For now the best place to validate public key seemes to the the pinAccount function. But I think implementing a redux middleware that makes sure the all the states that store addresses gets valid public key would be the best approach. |
|
Looks great, thanks.
Agreed, that might be a good follow up to work on if you're interested One change around typing requested then LGTM |
nathanleclaire
requested changes
Jul 13, 2022
nathanleclaire
requested changes
Jul 18, 2022
|
Almost there! Just one request to get rid of the |
|
Oh nice, I can just edit your repo 🤯 LGTM |
nathanleclaire
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistakeny added a invalid public key in
watchAccountPopoverwhich caused the entire app to break.I guess when I added the invalid address to watch, it got stored and is causing this issue even after I restart the app. Next, I will clear stored address from memory, and figure our any measures we can take if such address somehow gets stored. But, for now, this PR should prevent user from entering the invalid address.