Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer SOL renamed to Send SOL #219

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

sammanadh
Copy link
Contributor

  1. Transfer SOL button renamed to Send SOL
  2. Target account input disabled in send sol popup
    With this change there will no way to send SOL to an account without selecting it from ProgramChange comp. Will need to add another ui element using which a user will have the freedom to paste or type any address he/she wants.

2. Target account input disabled in send sol popup
With this change there will no way to send SOL to an account without selecting it from ProgramChange comp. Will need to add another ui element using which a user will have the freedom to paste or type any address he/she wants.
@nathanleclaire
Copy link
Contributor

nathanleclaire commented Jul 13, 2022

Nice!! CI wants you to take out targetPlaceholder prop in TransferSolButton

error  'targetPlaceholder' PropType is defined but prop is never used  react/no-unused-prop-types

@nathanleclaire
Copy link
Contributor

Closes #185

@sammanadh
Copy link
Contributor Author

Opps. forgot to add targetPlaceholder in props destructuring. just added.

@nathanleclaire
Copy link
Contributor

one more ask on this one --

Since the "From" and "To" fields cannot be modify -- can you please change them from being an <input> to a <code>?

And also label them, so that "From" says something like (Your Wallet) by it, and "To" says something like (This Account)

Screen Shot 2022-07-14 at 11 26 38 AM

Thanks!

@sammanadh
Copy link
Contributor Author

@nathanleclaire Have change input to code. Looks like this:
Screenshot from 2022-07-15 20-35-03
Also, have done some refactoring to make prettifyPubkey "importable"

@nathanleclaire
Copy link
Contributor

Nice!!

LGTM

@nathanleclaire nathanleclaire merged commit 0a4d1d5 into workbenchapp:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants