Modify default InlineKey len to 8 #224
Conversation
|
no? can we default to not reduced - as that's the normal - we have all the space we need, and reduce it only where its needed for UX - like changes.. |
| @@ -319,7 +319,7 @@ function AccountView(props: { pubKey: string | undefined }) { | |||
| <b>ATA</b> | |||
| <InlinePK | |||
| pk={tAccount.pubkey.toString()} | |||
| formatLength={9} | |||
| formatLength={8} | |||
There was a problem hiding this comment.
9 - as in 4chars + '...' + 4 chars
|
The reason I bring this up actually is because I want to stuff a "Tags" section in that table, ideally for 0.4.0 -- which would contain tags like |
src/renderer/components/InlinePK.tsx
Outdated
| @@ -105,7 +105,7 @@ const InlinePK: React.FC<{ | |||
|
|
|||
| InlinePK.defaultProps = { | |||
| className: '', | |||
| formatLength: 32, | |||
There was a problem hiding this comment.
please no, don't minimse by default - its a UX choice that should be only used where space is a constraint.
Sure
Do we? I think we tend to use monitors that are on the larger side. I want ideally WB to work pretty well out of the box on a small display, like a Macbook Air. And for the program changes in particular I think we could get more useful information in there |
|
yes - the non-truncated pubkey fits very well in the AccountView.... the table is quite different. but again - yes, truncate on the changes table, cos that is a space constrained thing. eventually, it should be responsive, not hard coded... |
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
nathanleclaire
force-pushed
the
be_fussy_about_pubkey_length
branch
from
20946e6
to
ffdb380
Compare
|
OK yea my fault, movin too quick on the original one. This is now closer to what I had in mind. Seems WB opens with the left pane quite aggressively expanded, and I always have to drag the right pane over lol -- we'll have to see if we can fix that up |
|
OMG. I just realised - we should both think more about this - I'll make a new issue! LGTM! |
|
thx for fast review! |
Closes #223
Signed-off-by: Nathan LeClaire nathan@cryptoworkbench.io