Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuals: clicking on sidebar item doesn't work in specific cases #688

Closed
UrtsiSantsi opened this issue Oct 16, 2023 · 4 comments
Closed

Comments

@UrtsiSantsi
Copy link
Contributor

Steps to reproduce:

  1. Open "Adw-1" -> "Additional Documentation" -> "Adaptive Layouts" from the sidebar. "Adaptive Layouts" page is opened.
  2. Click on "AdwClamp" link inside the "Adaptive Layouts" page.
  3. Click on "Adaptive Layouts" in the sidebar

Expected result:

  • "Adaptive Layouts" is opened.

Observed result:

  • Nothing happens.

This can be reproduced with any page.

@sonnyp
Copy link
Contributor

sonnyp commented Oct 16, 2023

This will be fixed with #682

@UrtsiSantsi
Copy link
Contributor Author

UrtsiSantsi commented Oct 23, 2023

@AkshayWarrier I tested your changes with a598cd8 and while now the rows are not collapsed, there are some regressions. Search for something, click on a row, click on link in the page, click on any row - the row is selected, but the page is not opened. Next click works. For example search for portal, click on XdpPortl row, click on GObject link in the page, click on any row:
image

I also got the feeling that clicking on a row in the search sidebar got slower.

@AkshayWarrier
Copy link
Contributor

Thanks for testing, but this happens because when you click on the "GObject" link, it's not actually loading the local documentation but it's opening an HTTP link to load it into the webview (which is also the reason why it takes longer to load it). This is true for all links that reference other docsets outside of its own one. If you click on the link for example xdp_portal_new, it'll work as expected because it refers to documentation from the same library and loads the local documentation.

I plan to change this in a future PR so that it redirects HTTP uris that refer other documentation to the local documentation if it has one. It's also one of the tasks listed on #640

So it's not really a regression but just a missing feature that hasn't been implemented yet.

@sonnyp
Copy link
Contributor

sonnyp commented Nov 15, 2023

@sonnyp sonnyp closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants