Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: optimized notification #227

Closed
wants to merge 4 commits into from
Closed

Conversation

Aryanryn09
Copy link

@Aryanryn09 Aryanryn09 commented Mar 14, 2023

this change is wrt This code uses object shorthand notation to set the properties of the Gio.Notification object, which makes the code more concise and easier to read. It also uses a loop to create and add the Gio.SimpleAction objects, which eliminates some repetition.issue workbenchdev/demos#3

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work. Did you test?

https://github.com/sonnyp/Workbench/blob/main/CONTRIBUTING.md#submitting-a-contribution

Make sure it's working by running Workbench and launching your entry via the Library.

With your changes and when loading the demo, the notification doesn't appear and the following appears in the console:

(re.sonny.Workbench.Devel:4): Gjs-WARNING **: 13:02:03.231: JS ERROR: Error: No property title on GNotification
@file:///tmp/workbench-0B9V11.js:6:22

Also, the file window.js appears to be an error.

Please make sure to review and test your changes before submitting a contribution.

@sonnyp sonnyp self-assigned this Mar 14, 2023
@sonnyp sonnyp closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants