library: Add Font Dialog Entry #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested changes
Mar 22, 2023
| console.log(`Font Dialog Button: The font selected is ${fontname}`); | ||
| }); | ||
|
|
||
| const dialog_custom = new Gtk.FontChooserDialog({ |
There was a problem hiding this comment.
okay, I'll update this with the new one
|
I'll fix it |
sonnyp
force-pushed
the
main
branch
3 times, most recently
from
05f69f1
to
55e450f
Compare
|
@SoNiC-HeRE please make sure to update this to use |
|
I'm unsure why I'm getting an empty object or undefined value when i'm trying to get the value from Gtk.FontDialog. It seems to work fine with Gtk.FontDialogButton but not with a custom button. I'm using this for reference: https://docs.gtk.org/gtk4/class.FontDialog.html |
|
The demo seems to be working now , had to fix an error. It is ready for review now |
sonnyp
pushed a commit
to krlade/Workbench
that referenced
this pull request
Jun 3, 2023
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Font Dialog Entry
workbenchdev/demos#3