Replace Black with Ruff, add LSP plugin for Ruff #902
Conversation
|
There's also a python-language-server Ruff plugin: We should be using that instead probably! |
theCapypara
force-pushed
the
capypara/add-ruff
branch
from
62db149
to
24a9c2e
Compare
theCapypara
changed the title
ruff.toml
Outdated
| "E402", # Module level import not at top of file -> gi imports may come after gi.require_version. | ||
| "E501", # Line too long. This is probably better enforced manually where it makes sense. | ||
| ] | ||
| select = [ "W", "E", "F", "ARG"] |
There was a problem hiding this comment.
please move this file to langs/python
or copy
let's use 2 separate files, one for Workbench internal and one for Workbench source
There was a problem hiding this comment.
What do you mean by two files?
I will move it to langs/python for now, but this makes running it locally a bit more complicated, though it's not a big issue since I can just configure it in the Makefile.
There was a problem hiding this comment.
we should use 2 separate configs anywya
1 for python source files in Workbench
1 for the LSP / formatter in Workbench
We'll want different rules
There was a problem hiding this comment.
Can we keep it one file for now? We can split it up later if needed anyway.
Workbench only has a handful of Python files internally, I doubt we couldn't use the same rule. I want to keep the rules as simple as possible in any case.
Co-authored-by: Sonny Piers <sonny@fastmail.net>
I decided to go ahead with trying to implement Ruff. Ruff implements a linter and a formatter. I added https://github.com/python-lsp/python-lsp-ruff for Ruff support for the existing LSP.
This removes Black and replaces it with Ruff. Ruff also runs linting.
Closes #804.