-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Implement static checks for demos #25
Comments
Note that even with this issue we can not check that the Blueprint files actually match the demos, this will require #24. |
See also https://github.com/sonnyp/Workbench/issues/638 but I don't think they are duplicates. |
We may also want to check for missing version requirements in the demo or missing init calls. See also workbenchdev/Workbench#738 |
Updated the issue to contain checkboxes for tasks and checked what is already implemented. |
I fixed that the other way around - Workbench now uses biome instead of prettier for formatting JS Since we already use Biome for CI on demos - this point can be checked EDIT: actually I rephrased it |
For GitHub actions (and locally using
make ci
), implement the following checks for all demos:eslint
rustfmt
prettier
Check XML againstwe don't have xml files in demosprettier
blueprint-compiler
'sfomat
command.pygobject-stubs
and eithermypy
orpyright
check that the demos pass static type checkstsc
andts-for-gir
)blueprint-compiler
Some of these are already implemented.
All tests must be executable based on the Flatpak SDK workbench uses (see existing CI taks in the Makefile).
Required boilerplate, configuration files and stubs should be kept to a minimum and somewhat isolated from the rest of the code base. However note that some of
prettier
and possible some other JS libraries for formatting are already bundled with Workbench and those should be used.I'm a bit unsure about the JS and Vala side of things, so some things may not make perfect sense, happy for comments on this!
This is related to #24, but the demos are not actually run, they are all checked statically. This should probably be constructed in a way that makes it somewhat easy to add testing to run the demos later on.
The text was updated successfully, but these errors were encountered: