Add proper Python typing to Welcome demo #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theCapypara
force-pushed
the
capypara/typing-python
branch
from
f1049d0
to
b337cd3
Compare
theCapypara
commented
Apr 22, 2024
| @@ -19,7 +21,7 @@ def dialog_response(dialog, response): | |||
| dialog.close() | |||
|
|
|||
|
|
|||
| subtitle_box: Gtk.Box = workbench.builder.get_object("subtitle") | |||
| subtitle_box = cast(Gtk.Box, workbench.builder.get_object("subtitle")) | |||
There was a problem hiding this comment.
This is needed, otherwise mypy complains:
src/Welcome/main.py:22: error: Incompatible types in assignment (expression has type "Object | None", variable has type "Box") [assignment]
Found 1 error in 1 file (checked 1 source file)
We will need to add these casts everywhere where the concrete return type can vary.
There was a problem hiding this comment.
cast is just the identity function at runtime: https://docs.python.org/3/library/typing.html#typing.cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a draft because it's meant for discussion and not to be merged yet; relates to #25)
This changes the "Welcome" demo so that it passes "mypy" type checks.
To achieve this, a mypy configuration file is added and a Python package which provides type information for the "workbench" module. See notes in the README file I added for some concerns we need to clarify first.
"mypy" has "python-lsp" integration via https://github.com/python-lsp/pylsp-mypy.