CFLT plugin very minor renaming & refactoring #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrible Very minor refactoring and renaming to make the code a tiny bit less terrible
|
So this is just a minor refactor but wanted to merge in cause it'll be easier to review rather than having a huge PR down the line. There's generally a LOT that can be improved here, repeated logic in the drawing tools, the weird vertex name augmentation for dealing with iteration and the over-complicated AdvancedGraph and Optimal ECC calculation obviously need to be replaced with something much better. But I'll do those in separate PR's if I have time in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this plugin at Uni back in 2021/ 2022, looking back now the code is absolutely terrible so I spent a day making it slightly less awful.