Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable OAuth Scopes via Environment Variables #1056

Merged
merged 5 commits into from
May 1, 2024

Conversation

torkashvand
Copy link
Contributor

@torkashvand torkashvand commented Apr 26, 2024

Issue:
The authorization scopes for OAuth are currently hardcoded in the NextAuth.js configuration, limiting operational flexibility across different environments.

Link to the issue: #1055

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 47ce8ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@orchestrator-ui/orchestrator-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

turbo.json Outdated Show resolved Hide resolved
@ricardovdheijden
Copy link
Collaborator

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

@torkashvand
Copy link
Contributor Author

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

Thanks, I will apply your suggestion but first I need to create another PR for my first PR on the submodule repo which has been merged.

I will add you as a reviewer on that PR as well.

@torkashvand torkashvand force-pushed the issue-1055-configurable-oauth-scopes branch 2 times, most recently from 11624cc to 26cba13 Compare April 29, 2024 10:34
@ricardovdheijden
Copy link
Collaborator

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

Thanks, I will apply your suggestion but first I need to create another PR for my first PR on the submodule repo which has been merged.

I will add you as a reviewer on that PR as well.

Yes, will have a look then. Also I just added a commit to your branch/PR. It contains a changeset file for collecting release notes for publishing to NPM.

@torkashvand
Copy link
Contributor Author

@ricardovdheijden Thanks for approving my PR. I think it needs two approves. correct?

@ricardovdheijden
Copy link
Collaborator

@ricardovdheijden Thanks for approving my PR. I think it needs two approves. correct?

Yes indeed, added some reviewers

@torkashvand torkashvand force-pushed the issue-1055-configurable-oauth-scopes branch from 883692d to 47ce8ff Compare May 1, 2024 14:33
@torkashvand torkashvand merged commit 71fa3bd into main May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants