Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze: improve documentation to better explain what "entry points" are and how many are necessary #65

Closed
evanweible-wf opened this issue Sep 2, 2015 · 4 comments
Assignees

Comments

@evanweible-wf
Copy link
Contributor

The dartanalyzer follows imports, which means it's only necessary to analyze the top-level entry points since all other files (that are imported) will be reachable and will be analyzed.

On this same note, the "entryPoints" config option may not be very intuitive since it accepts directories or files and expands directories to look for all top-level files. We may want to leave the file expansion to the shell and only accept a list of files.

@trentgrover-wf
Copy link
Contributor

analyze didn't find an unused import that I added to a test/subdir file that is definitely imported by a file at the test level...

@evanweible-wf
Copy link
Contributor Author

One possible addition that might provide some value would be building a list of all .dart files in a project and comparing that list to the list of files analyzed by dartanalyzer according to the projects dart_dev config. Then we could provide a list of files that weren't analyzed as a warning to the project maintainer
Would help detect entry points that just haven't been defined in the dart_dev config as well as .dart files that may be unused

@charliekump-wf charliekump-wf changed the title Analyze: improve documentation to better explain what "entry points" are and how many are necessary CP-2136 Analyze: improve documentation to better explain what "entry points" are and how many are necessary Jul 28, 2016
@evanweible-wf
Copy link
Contributor Author

Should incorporate some of the info from this: https://gist.github.com/evanweible-wf/cd69694cdd062746a6f0ad4c5fbd55b3 into the documentation for AnalyzeTool in v3.

@evanweible-wf evanweible-wf self-assigned this Oct 9, 2019
@evanweible-wf evanweible-wf removed this from the 2.0.0 milestone Oct 9, 2019
@evanweible-wf evanweible-wf changed the title CP-2136 Analyze: improve documentation to better explain what "entry points" are and how many are necessary Analyze: improve documentation to better explain what "entry points" are and how many are necessary Oct 9, 2019
@evanweible-wf
Copy link
Contributor Author

This has been simplified with improvements to analyzer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants