Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint issues #1038

Closed
alexanmtz opened this issue Jan 12, 2024 · 20 comments · Fixed by #1107
Closed

Fix Lint issues #1038

alexanmtz opened this issue Jan 12, 2024 · 20 comments · Fixed by #1107
Labels
beginner tasks status of beginner bounty bug
Milestone

Comments

@alexanmtz
Copy link
Member

When you do a push you will see many lint errors, and we need all those fixes so we can have the push hook green

@alexanmtz alexanmtz added this to the v2.0 milestone Jan 12, 2024
@alexanmtz alexanmtz added bug beginner tasks status of beginner contribution labels Jan 12, 2024
@alexanmtz
Copy link
Member Author

@KenjxJJ can you work on this?

@KenjxJJ
Copy link
Contributor

KenjxJJ commented Jan 16, 2024

Yes.

@alexanmtz alexanmtz assigned KenjxJJ and alexanmtz and unassigned alexanmtz Jan 16, 2024
@effaf
Copy link

effaf commented Feb 9, 2024

Hi @alexanmtz , I would like to work on this if there is no resolution yet.

@alexanmtz
Copy link
Member Author

Hello @effaf , there's no resolution yet; feel free to work on it.

@effaf
Copy link

effaf commented Feb 10, 2024

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

@alexanmtz
Copy link
Member Author

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

Hey, @effaf, thanks for jumping into this issue and your proactivity. You can change the ecmaVersion in the configuration, and we can eliminate all console.logs except the one with the comment // eslint-disable-next-line no-console

And we can remove the unused libraries.

@alexanmtz
Copy link
Member Author

Hey @effaf, some progress on this one?

@alexanmtz
Copy link
Member Author

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

@guvitorino
Copy link

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

I started working on this issue. I saw the comments above and will take them into consideration

@alexanmtz
Copy link
Member Author

That's great @guvitorino, looking forward to review your solution and feel free to change the configuration as suggested before

and fix automatically some issues with npm run lint-fix

@Anshgrover23
Copy link

hi i am also doing this

@Anshgrover23
Copy link

/attempted Fix Lint issues #1038, plss check @alexanmtz also there is some parsing error were not resolving can u plss check

@Anshgrover23
Copy link

/claim #1038

1 similar comment
@CodeWithInferno
Copy link

/claim #1038

@alexanmtz
Copy link
Member Author

Hello @Anshgrover23 , thanks for sending the PR, I will review in the weekend and when it's merged you can claim the bounty on the web page by going in "Solve issue" and pasting your PR when is merged in "Send Solution" tab

@alexanmtz
Copy link
Member Author

Hey @guvitorino, we have already a PR to review for this one, so let's find another issue for you :)

@Anshgrover23
Copy link

@alexanmtz thanks buddy, waiting for your merge reply and thanks for giving me chance

@Anshgrover23
Copy link

@alexanmtz made some more commit changes review the pr once again please sir.

@Anshgrover23
Copy link

@alexanmtz solved the optonal chaining errors . check new commit

@raviteja83 raviteja83 mentioned this issue Jun 20, 2024
3 tasks
@alexanmtz
Copy link
Member Author

Hey @raviteja83, you fixed this issue successfully; many thanks for the contribution 🚀

You can claim your bounty by visiting this issue on Gitpay: https://gitpay.me/#/profile/task/840/fix-lint-issues

On "Solve Issue" and on the "Send Solution" tab, you can paste the PR merged and the Bounty process will be initiated I hope :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner tasks status of beginner bounty bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@alexanmtz @guvitorino @effaf @KenjxJJ @CodeWithInferno @Anshgrover23 and others