Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import issue "Error to update issue" #1083

Closed
Zahrun opened this issue Apr 5, 2024 · 6 comments
Closed

Cannot import issue "Error to update issue" #1083

Zahrun opened this issue Apr 5, 2024 · 6 comments

Comments

@Zahrun
Copy link

Zahrun commented Apr 5, 2024

Hi there,

I want to fund some issues: mono/mono#14412 and keepassxreboot/keepassxc#2281.

When I click on "import issue" and input any of these two issues url, it shows "Error to update issue".

@Zahrun
Copy link
Author

Zahrun commented Apr 5, 2024

https://github.com/worknenjoy/gitpay/issues/1083 also fails

@alexanmtz
Copy link
Member

@Zahrun, we have solved it for now; some of the issues already exist, and we have better feedback now. I think there's a case when the Github API limit is exceeded, and now we have a specific notification for it. We will work to better handle Github API calls or even not depend on them if they're not available in the near future.

Can you test again?

FireShot Capture 001 - Gitpay - Bounties for git issues solved - gitpay me

@Zahrun
Copy link
Author

Zahrun commented Apr 9, 2024

I found under my profile the 3 issues were already created. I deleted the one related to #1083 and then created it again. Tried that on mobile the other day and it failed with "actions.task.issues.error.notfound". Maybe deleting and recreating is not supported. Now from laptop I tried again and got "Error to update issue" then refreshed the my profile and it was in the list, created "a few seconds ago".
I cleared cookies and site data, reloaded the page, added a different issue https://github.com/pacstall/chaotic-PPR/issues/5, and got again "Error to update issue". Refreshed the profile, and the issue is listed there as actually created.

@alexanmtz
Copy link
Member

I found under my profile the 3 issues were already created. I deleted the one related to #1083 and then created it again. Tried that on mobile the other day and it failed with "actions.task.issues.error.notfound". Maybe deleting and recreating is not supported. Now from laptop I tried again and got "Error to update issue" then refreshed the my profile and it was in the list, created "a few seconds ago". I cleared cookies and site data, reloaded the page, added a different issue https://github.com/pacstall/chaotic-PPR/issues/5, and got again "Error to update issue". Refreshed the profile, and the issue is listed there as actually created.

Thanks for reporting, @zahru, I will work to fix those bugs.

@alexanmtz
Copy link
Member

Hey @Zahrun, thanks again for catching all bugs and reporting to us; now I believe these bugs are solved on my last commits: eb1ed4c 05fb7a2

Now we verify that the API limit was explicitly exceeded, and the error scenarios with the import process you described were mostly fixed, as the not found and error on update cases.

Let me know if there's any issue; otherwise, we can close this one 🤞

@Zahrun
Copy link
Author

Zahrun commented Apr 13, 2024

Issue created successfully on Gitpay
This issue was imported already

It seems to work, very nice, thank you

@Zahrun Zahrun closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@alexanmtz @Zahrun and others