Fix for Issue #1013 #1070
Merged
Fix for Issue #1013 #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with tests for previous code base is at Transfer.update() |
|
I think hooks need to be setup like it was done for Task to store update history. |
|
tests pass for node v17.3.0 |
alexanmtz
approved these changes
Feb 20, 2024
|
Great @webbdays with the solution, I just changed the name of the component to make it more concise, but great job and well done with the build fix! 🎉 |
|
Thank you. |
|
But tests for new functionality in frontend are not covered. And also code docs. |
|
@webbdays I will have to revert this PR, still an issue on the logged page: Please check it and create a new PR with your fixes. |
alexanmtz
added a commit
that referenced
this pull request
Feb 20, 2024
|
ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
To allow user to sort the columns in a table
Purpose
To allow user to sort the columns in a table
Solution
Using TableSortLabel component from MUI, Got to know about it after seeing the PR's related to this issue.
Screenshots
None
Checklist
Related Issues
None
Additional Notes
None
Contributor Guidelines
Fork the repo and create your branch from master. - done
If you've added code that should be tested, add tests. - not yet
If you've changed APIs, update the documentation. - NA
Ensure the test suite passes. - tests on previous codebase are failing
Make sure your code lints. - linting on previous codebase are failing
Issue that pull request! - going to do it
Check if the build is green before we start to review - waiting
Thank you.