Feat/sync issues status with GitHub webhooks

[SavvyShah]

Description

This allows to sync the issue status on Github with our website.

Changes

• /modules/app/controllers/webhooks.js
• /test/webhook.test.js

Issue

#484

Impacted Area

I've added update query so database gets updated.
All the pages where issue status is displayed

Steps to test

Steps needed to reproduce the scenario from this change to validate if the pull request solve this issue

• I have added the test in /test/webhook.test.js
• Similar to the test you can create your own and test if the thing works.

Some other steps you can follow(requires postman)

• Start the backend server.
• (Optional)Start pgAdmin to see change in database.
• Send post requests through postman with the data as json.

Before

Screenshot from the state before

After

Screenshot from the state after your Pull Request

[alexanmtz]

@ShubhamCanMakeCommit please check the build failing:
https://circleci.com/gh/worknenjoy/gitpay/1143

[SavvyShah]

It is not showing when I run the tests. I will try to solve. Maybe you can tell what might be going wrong.

[SavvyShah]

Okay, there is a problem in my test. I will solve that.

[alexanmtz]

You can see that maybe is missing the authorization when calling the webhook from the tests as the following tests:
https://github.com/ShubhamCanMakeCommit/gitpay/blob/feat/sync-issues-status-with-github-webhooks/test/webhook.test.js#L407

[alexanmtz]

The solution is good! Some improvements to do the update and return the updated model.

[alexanmtz]

@ShubhamCanMakeCommit Once you returned the update method with the returning parameter, you will no longer need to call a find and you need to change the checks accordingly. Please make the changes and test again, we are almost there ✋

[alexanmtz]

Thanks @ShubhamCanMakeCommit , now we need to notify our users as described on the issue. When update, we should call a new mail function with the following template:

Hello {{name}},

The issue {{title}} - {{url}} was closed on Github, so we closed on Gitpay. 

You can change the issue status if you want.
 
Thanks,
Gitpay Team

----------------------
https://gitpay.me (Web)
tarefas@gitpay.me (Email)
Worknenjoy Inc., 2035 Sunset Lake Road #Suite B-2, Newark, DE 19702 (Mail)

So check the existent mail functions to create new notification templates.

You think is possible to do that?

[SavvyShah]

Oh, yes I forgot about that one. I would do that.

…

On Wed, Mar 18, 2020, 9:02 PM Alexandre Magno ***@***.***> wrote: Thanks @ShubhamCanMakeCommit <https://github.com/ShubhamCanMakeCommit> , now we need to notify our users as described on the issue. When update, we should call a new mail function with the following template: Hello {{name}}, The issue {{title}} - {{url}} was closed on Github, so we closed on Gitpay. You can change the issue status if you want. Thanks, Gitpay Team ----------------------https://gitpay.me ***@***.*** (Email) Worknenjoy Inc., 2035 Sunset Lake Road #Suite B-2, Newark, DE 19702 (Mail) So check the existent mail functions to create new notification templates. You think is possible to do that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#501 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMRHRR65JR2R7NMQHYIZQQTRIDSQ5ANCNFSM4LNSPKUA> .

[alexanmtz]

Great @ShubhamCanMakeCommit , now we can proceed and merge 🚀

[alexanmtz]

@ShubhamCanMakeCommit , I will test creating an issue and closing to see it in action 👍