Feature/sdk 94 add delete directory api endpoint to net #33
Conversation
|
Could we add a test for this? |
| /// An optional token to cancel the request. | ||
| /// </param> | ||
| /// <returns>A Task wrapping a deleted WorkOS Directory record.</returns> | ||
| public async Task<Directory> DeleteDirectory(string id, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
This return type isn't correct, as we don't return a Directory from the endpoint.
We just return a HTTP 202 with no body, so the return type for this method should just be Task.
There was a problem hiding this comment.
@maxdeviant When using public async Task DeleteDirectory, I seem to get this error:
Since 'DirectorySyncService.DeleteDirectory(string, CancellationToken)' is an async method that returns 'Task', a return keyword must not be followed by an object expression. Did you intend to return 'Task<T>'?
Are there other adjustments needed to make this change?
There was a problem hiding this comment.
@logangingerich You can't return anything from a method that returns Task instead of Task<T>, so you'll need to discard the result of the API request:
await this.Client.MakeAPIRequestAsync<Directory>(request, cancellationToken)instead of
return await this.Client.MakeAPIRequestAsync<Directory>(request, cancellationToken)
My .NET knowledge is pretty limited and unfortunately there are no existing tests for deletion in this SDK to reference (there's no test for the delete connection endpoint). But I'm working on it 😅 |
logangingerich
deleted the
feature/sdk-94-add-delete-directory-api-endpoint-to-net
branch
Adds a Delete Directory API Endpoint and corresponding test.