Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MFA module #22

Merged
merged 3 commits into from Dec 22, 2022
Merged

Add MFA module #22

merged 3 commits into from Dec 22, 2022

Conversation

jacobiajohnson
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Dec 22, 2022

@jacobiajohnson
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Contributor

@blairlunceford blairlunceford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had one question, but it's not critical.

"authentication_factor_id": "auth_factor_01FVYZ5QM8N98T9ME5BCB2BBMJ"
}}

iex> WorkOS.MFA.challenge_factor(%{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a copy of the example above but am I missing something - are these different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I meant to include sms_template in the second one to show that it's optional. will update it

@jacobiajohnson jacobiajohnson merged commit ab6f0e5 into main Dec 22, 2022
@jacobiajohnson jacobiajohnson deleted the feature/sdk-632-add-mfa-api branch December 22, 2022 17:40
@blairlunceford blairlunceford mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants