-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new SSO module and tests structure #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LauraBeatris
changed the title
Introduce SSO module improvements
[WIP] Introduce SSO module improvements
Oct 28, 2023
LauraBeatris
force-pushed
the
update-sso-module
branch
2 times, most recently
from
October 28, 2023 21:08
b5a6096
to
bf32d12
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
2 times, most recently
from
October 28, 2023 21:22
4c81c86
to
90f37d6
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
October 28, 2023 21:35
90f37d6
to
f4a7e10
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
2 times, most recently
from
October 29, 2023 17:28
431819d
to
f9f8054
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
October 29, 2023 17:31
f9f8054
to
a77251b
Compare
LauraBeatris
commented
Oct 29, 2023
LauraBeatris
force-pushed
the
update-sso-module
branch
2 times, most recently
from
October 29, 2023 17:59
b5e2768
to
3da041f
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
October 29, 2023 18:05
3da041f
to
6b310e6
Compare
LauraBeatris
commented
Oct 29, 2023
LauraBeatris
force-pushed
the
update-sso-module
branch
from
October 29, 2023 20:40
5ff0c3a
to
14447d5
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
November 8, 2023 02:03
fcc9ac1
to
949d1fd
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
November 8, 2023 12:56
8f08b62
to
f7abee8
Compare
…e application config loaded
LauraBeatris
force-pushed
the
update-sso-module
branch
from
November 9, 2023 18:36
cc928d0
to
3dbc9d7
Compare
LauraBeatris
force-pushed
the
update-sso-module
branch
from
November 9, 2023 20:03
5139fda
to
6539d62
Compare
LauraBeatris
changed the title
[WIP] Introduce SSO module improvements
Introduce new SSO module and new tests structure
Nov 9, 2023
LauraBeatris
changed the title
Introduce new SSO module and new tests structure
Introduce new SSO module and tests structure
Nov 9, 2023
LauraBeatris
requested review from
marktran,
blairlunceford and
jacobiajohnson
November 9, 2023 22:23
marktran
approved these changes
Nov 9, 2023
LauraBeatris
added a commit
that referenced
this pull request
Dec 4, 2023
* Update `mix.exs` * Add util module * Add `Connection` struct * Add `List` castable module * Add `list_connections` method * Add `delete_connection` method * Add `get_connection` method * Add draft for `get_authorization_url` * Add `dialyxir` dependency * Remove old SSO module * Define logic for `get_authorization_url` * Add `Profile` and `ProfileAndToken` response structs * Add `get_profile` function * Add basic layer for tests * Add structs to `mix.exs` * Fix guard on `get_authorization_url` * Remove deprecated tests * Add doc comments for parameter options of `get_authorization_url` * Remove `Application.put_env` from `test_helper` * Add draft test * Fix extension of test files to `exs` * Apply case for test config * Define base URL for test * Fix test * Implement tests for `get_authorization_url` * Define test for `get_profile_and_token` * Implement tests for `get_profile_and_token` * Implement tests for `get_profile` * Implement test for `get_connection` * Implement test for `list_connections` * Rename `ClientMock` to `SSO.ClientMock` * Implement test for `delete_connection` * Fix return type for `delete_connection` * Fix `mix credo` issues * Update comment indentation * Handle case where `get_authorization_url` is called without having the application config loaded * Add validation for `redirect_uri` * Include `client_id` on WorkOS Client * Update livebook examples * Fix connection struct * Add `WorkOS.Empty` * Remove `IO.inspect`
LauraBeatris
added a commit
that referenced
this pull request
Dec 20, 2023
* Introduce HTTP client and base URL as configuration options (#37) * Add config modules * Start to build behavior for HTTP client * Add `Castable` module to define behavior for casting or transforming data * Handle response * Add HTTP methods to client behavior * Add `TeslaClient` implementation * Add comment to prod.exs to fix `mix format` * Fix casing for `WorkOS` namespace * Add `@deprecated` to `WorkOS.API` * Fix test config * Validate config * Fix linter * Add module for structured error response * Extract env variables to separate variables * Add livebook example (#38) * Add `ISSUE_TEMPLATE.md` (#34) * Permit `expires_in` param when creating passwordless session (#35) Co-authored-by: Mark Tran <mark.tran@gmail.com> * Start to build behavior for HTTP client * Add `Castable` module to define behavior for casting or transforming data * Handle response * Add HTTP methods to client behavior * Add `TeslaClient` implementation * Add comment to prod.exs to fix `mix format` * Fix casing for `WorkOS` namespace * Add `@deprecated` to `WorkOS.API` * Fix test config * Validate config * Fix linter * Add livebook file --------- Co-authored-by: Jordan Mackie <12185627+jmackie@users.noreply.github.com> Co-authored-by: Mark Tran <mark.tran@gmail.com> * Introduce new SSO module and tests structure (#39) * Update `mix.exs` * Add util module * Add `Connection` struct * Add `List` castable module * Add `list_connections` method * Add `delete_connection` method * Add `get_connection` method * Add draft for `get_authorization_url` * Add `dialyxir` dependency * Remove old SSO module * Define logic for `get_authorization_url` * Add `Profile` and `ProfileAndToken` response structs * Add `get_profile` function * Add basic layer for tests * Add structs to `mix.exs` * Fix guard on `get_authorization_url` * Remove deprecated tests * Add doc comments for parameter options of `get_authorization_url` * Remove `Application.put_env` from `test_helper` * Add draft test * Fix extension of test files to `exs` * Apply case for test config * Define base URL for test * Fix test * Implement tests for `get_authorization_url` * Define test for `get_profile_and_token` * Implement tests for `get_profile_and_token` * Implement tests for `get_profile` * Implement test for `get_connection` * Implement test for `list_connections` * Rename `ClientMock` to `SSO.ClientMock` * Implement test for `delete_connection` * Fix return type for `delete_connection` * Fix `mix credo` issues * Update comment indentation * Handle case where `get_authorization_url` is called without having the application config loaded * Add validation for `redirect_uri` * Include `client_id` on WorkOS Client * Update livebook examples * Fix connection struct * Add `WorkOS.Empty` * Remove `IO.inspect` * Refactor `Organizations` module (#44) * Add skeleton for Organizations module * Remove old `Organizations` module * Add missing `object` key to connections domain * Add response struct for organizations * Implement functions for `Organization` module * Add `create_organization` and `update_organization` * Extract exceptions to separate modules * Allow to call `list` functions without client and map args * Implement tests for organizations * Update Livebook examples * Remove `Logger` * Remove `WorkOS.Util` and fix timestamps * Refactor `Portal` module (#45) * Add basic modules * Define function clauses * Include implementation * Add Portal link response struct * Add portal client mock * Implement tests * Add example to Livebook * Refactor `Webhooks` module (#46) * Restructure modules * Add `Event` struct to `mix.exs` * Refactor `DirectorySync` module (#47) * Add base modules * Implement `get_directory` * Implement `list_directories` * Implement `delete_directory` * Implement `Directory.User` * Add tests for directory users * Remove `WorkOS.Util` * Add Livebook examples * Rollback `Util` changes * Remove `DateTime` from timestamps to match API reference * Add missing `object` keys to response structs * Remove WorkOS.Util * Refactor `Passwordless` module (#48) * Add base modules * Implement functions * Implement tests * Remove `message` property * Add `Events` module (#49) * Add base modules * Implement `list_events` * Implement tests * Add to Livebook * Refactor `AuditLogs` module (#50) * Add export response struct * Add base modules * Add implementation for `create_export` * Add tests for `create_export` * Add `get_export` method * Add `add_event` method * Add examples to Livebook * Remove MFA module (#51) * Add User Management API (#53) * Add draft for User Management module * Add `Invitation` struct * Add `User` struct * Add User API methods * Add methods from `Invitation` API * Add `OrganizationMembership` API methods * Add Password Reset API methods * Add Email Verification API methods * Add MFA response structs * Add Multi-Factor API methods * Add Magic Auth API methods * Add Authentication API methods * Add `get_authorization_url` * Update Livebook * Fixes `authorize` parameters * Add Domain Verification API (#55) * Remove legacy `WorkOS.API` * Add `OrganizationDomain` struct * Add Domain Verification API methods * Add domain verification API methods * Update README.md * Format modules * Fix `credo` issues * Fix dialyzer issues * Rename `DomainVerification` to `OrganizationDomains` (#56) * Rename to `OrganizationDomains` * Add to Livebook * Remove `domain` option and add tests for error case * Update workflow * Bump to `1.0.0` * Introduce Dialyzer artifacts * Remove `:hackney` * Update `elixirc_paths` * Rollback `elixirc_paths` * Import `ExUnit.Assertions` on mock files * Update `plug_crypto` * Update `jason` * Remove support for oldest OTP version * Update `dialyxir` * Remove enum constants * Update mock API keys * Add deprecated `MFA` API module (#58) * Fix timestamp mapping * Add deprecated response structs * Add deprecated API * Add tests * Fix generate_link types * Install `hackney` * Fix query params * Fix `list_groups` params * Fix `send_session` route from Magic Link * Pass `code` as keyword argument * Fix `challenge_factor` * Fix `get_organization` snippet from Livebook * Add organization ID as parameter on `update_organization` * Add `semaphore.yml` * Fix `WorkOS.Empty` struct * Fix `get_profile_and_token` snippet on Livebook * Fix `get_profile` Livebook snippet * Add experimental disclaimer back to README.md * Rollback semaphore * Rollback `elixir.yml` workflow due to branch policies --------- Co-authored-by: Jordan Mackie <12185627+jmackie@users.noreply.github.com> Co-authored-by: Mark Tran <mark.tran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes
exs
. Those weren't loading due to being defined asex
.Summary
SSO
module. This helps the developers to quickly know what to pass to a function and what to expect to return.WorkOS.Client
and remove the deprecatedWorkOS.API
fromSSO
module.mix.ex
with the modules group. This will be helpful when looking at ExDocs.Usage