Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing some Axios instance properties #653

Closed
wants to merge 1 commit into from

Conversation

jdforsythe
Copy link

Fixes #652
Fixes #627

This adds three specific Axios options to WorkOSOptions: adapter, httpsAgent, and proxy.

The first two options address the issues listed above. The proxy may be needed in some instances. I specifically used Pick to pull only these properties to keep the consumer from messing up the functionality by passing in a different baseUrl or other properties.

@maxdeviant
Copy link
Contributor

Thanks for the PR!

We've implemented this separately in #657.

@maxdeviant maxdeviant closed this Aug 18, 2022
@jdforsythe jdforsythe deleted the 652-axios-options branch August 19, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node versions before 10 do not support new WorkOS Root CA Allow customization of Axios instance
2 participants