Edit directory user interface to reflect nullable attributes #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSYNC-846 Fix Node SDK
Ensure the following attributes are nullable for the directory user in the Node SDK: firstName lastName username |
lukemorales
reviewed
Nov 10, 2023
lukemorales
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE - PUT IN MAJOR RELEASE
Fixes the directory user interface to accurately reflect the typing of attributes in the API.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
Docs PR: https://github.com/workos/workos/pull/23767