Add MFA support #116
Merged
Add MFA support #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Method signatures look good to me, would love someone with more Python prowess to give a look as well 👀 |
maxdeviant
reviewed
Mar 11, 2022
maxdeviant
reviewed
Mar 11, 2022
|
@awolfden Can you change the version for a pre-release version (believe it would be 1.11.0.a1 https://pythonpackaging.info/07-Package-Release.html) |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 95.08% 94.88% -0.20%
==========================================
Files 18 19 +1
Lines 488 528 +40
==========================================
+ Hits 464 501 +37
- Misses 24 27 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@awolfden @robframpton , published can be retrieved by |
robframpton
reviewed
Mar 24, 2022
robframpton
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
@awolfden once the __version__ change I suggested is committed this will be good to go.
Co-authored-by: Robert Frampton <rob@workos.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MFA to Python SDK