Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor methods to use WorkOS object classes and update tests #135

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

awolfden
Copy link
Contributor

Refactor methods to use WorkOS object classes and update tests

@awolfden awolfden requested a review from a team as a code owner July 19, 2022 15:07
@linear
Copy link

linear bot commented Jul 19, 2022

SDK-556 Python Improvements

Suggested by Adam W:

Python SDK cleanup - many of the methods do not follow the same code style or use classes for the params. We should update it to be uniform across all the methods/classes.

@awolfden awolfden requested a review from pliao28 July 19, 2022 15:07
@codecov-commenter
Copy link

Codecov Report

Merging #135 (d063d4c) into main (7e91299) will increase coverage by 0.51%.
The diff coverage is 97.84%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   93.25%   93.76%   +0.51%     
==========================================
  Files          22       24       +2     
  Lines         578      658      +80     
==========================================
+ Hits          539      617      +78     
- Misses         39       41       +2     
Impacted Files Coverage Δ
workos/directory_sync.py 84.61% <77.77%> (-2.62%) ⬇️
workos/mfa.py 100.00% <100.00%> (ø)
workos/organizations.py 90.90% <100.00%> (+1.25%) ⬆️
workos/passwordless.py 100.00% <100.00%> (ø)
workos/resources/directory_sync.py 100.00% <100.00%> (ø)
workos/resources/mfa.py 100.00% <100.00%> (ø)
workos/resources/organizations.py 100.00% <100.00%> (ø)
workos/resources/passwordless.py 100.00% <100.00%> (ø)
workos/resources/sso.py 81.81% <100.00%> (+10.38%) ⬆️
workos/sso.py 95.89% <100.00%> (+0.05%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@logangingerich logangingerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superb

@awolfden awolfden merged commit 78f7056 into main Jul 20, 2022
@awolfden awolfden deleted the feature/sdk-556-python-improvements branch July 20, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants