Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.27.0 #190

Merged
merged 3 commits into from
Aug 11, 2023
Merged

v1.27.0 #190

merged 3 commits into from
Aug 11, 2023

Conversation

pliao28
Copy link
Contributor

@pliao28 pliao28 commented Aug 4, 2023

Description

Version bump for fix to add expires_in and remove connections arg to create passwordless session call.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@pliao28 pliao28 requested a review from a team as a code owner August 4, 2023 17:33
@pliao28 pliao28 requested review from maxdeviant and removed request for a team August 4, 2023 17:33
@maxdeviant maxdeviant changed the title version bump 1.26.1 v1.26.1 Aug 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #190 (b3d4afd) into main (976a32d) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          28       28           
  Lines        1001     1001           
=======================================
  Hits          865      865           
  Misses        136      136           
Files Changed Coverage Δ
workos/__about__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxdeviant
Copy link
Contributor

Seems like this should be a minor version bump to v1.27.0, since we're adding functionality (and also removing functionality, which is technically a breaking change, but I just checked and it seems like there is no usage of the connection parameter from the Python SDK).

@pliao28
Copy link
Contributor Author

pliao28 commented Aug 9, 2023

Seems like this should be a minor version bump to v1.27.0, since we're adding functionality (and also removing functionality, which is technically a breaking change, but I just checked and it seems like there is no usage of the connection parameter from the Python SDK).

Yeah I can bump it back up to 1.27.0 then. We don't list the use of this connection param so no one should be using it.

@maxdeviant maxdeviant changed the title v1.26.1 v1.27.0 Aug 9, 2023
@pliao28 pliao28 merged commit b5a267c into main Aug 11, 2023
8 checks passed
@pliao28 pliao28 deleted the v1.26.1 branch August 11, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants