Add organization membership deactivate and reactivate API methods #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,6 +307,7 @@ def list_organization_memberships( | |||
| Kwargs: | |||
| user_id (str): Filter Organization Memberships by user. (Optional) | |||
| organization_id (str): Filter Organization Memberships by organization. (Optional) | |||
| statuses (list): Filter Organization Memberships by status. (Optional) | |||
There was a problem hiding this comment.
do we generally use this naming pattern for list params?
There was a problem hiding this comment.
Do mean the pluralized parameter name? Seems like we do in the Python SDK:
https://github.com/workos/workos-python/blob/main/workos/organizations.py#L41
https://github.com/workos/workos-python/blob/main/workos/events.py#L38
There was a problem hiding this comment.
no strong opinion, but statuses seems a bit weird. Maybe status_list ?
There was a problem hiding this comment.
Down to change it. That being said statuses is how it's defined in the API/other SDKs. Maybe it's better to be consistent, thoughts?
There was a problem hiding this comment.
I think we should be consistent and stick with statuses.
…on-membership-method-to-python-sdk
PaulAsjes
approved these changes
May 17, 2024
mattgd
deleted the
feature/dsync-1391-add-deactivate-organization-membership-method-to-python-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add organization membership deactivate and reactivate API methods.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.