Handle Content-Type headers that contain an encoding
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
reviewed
Sep 15, 2021
tests/conftest.py
Outdated
| @@ -11,7 +11,7 @@ def __init__(self, response_dict, status_code, headers=None): | |||
| self.headers = {} if headers is None else headers | |||
|
|
|||
| if "content-type" not in self.headers: | |||
| self.headers["content-type"] = "application/json" | |||
| self.headers["content-type"] = "application/json; charset=utf-8" | |||
There was a problem hiding this comment.
Could we leave this as-is and instead add two tests that set the Content-Type to application/json and application/json; charset=utf-8 to ensure that both parse the JSON response as expected?
maxdeviant
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Content-Typeheader is frequently sent likeapplication/json, but it can also contain extra "subtypes" like; charset=utf8. This leads to an issue with our response handling, as it compares the entire header value (likeapplication/json; charset=urf8) againstapplication/jsonto determine if the response was JSON.These changes make that check less exact, and instead we only look to see if the header contains
application/json, and then attempt to deserialize JSON.