Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for spaces in path to npm on windows #17

Closed
wants to merge 3 commits into from
Closed

Fix for spaces in path to npm on windows #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8da3c9
update for which
No9 Mar 24, 2015
2022b12
single quotes
No9 Mar 24, 2015
54e5f70
single quotes
No9 Mar 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions problems/00-install-npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ exports.verify = function (args, cb) {

try {
npm = which.sync('npm')
npm = 'npm'
} catch (er) {
console.error('It looks like npm is not installed.')
return cb(false)
Expand Down
2 changes: 1 addition & 1 deletion problems/05-login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ exports.verify = function (args, cb) {

// test who we are with whoami
var exec = require('child_process').exec
var npm = require('which').sync('npm')
var npm = 'npm'
exec(npm + ' whoami', function (er, stdout, stderr) {
if (er) {
process.stdout.write(stdout)
Expand Down
2 changes: 1 addition & 1 deletion problems/06-package-niceties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ exports.verify = function (args, cb) {

// make sure we get no warnings
var exec = require('child_process').exec
var npm = require('which').sync('npm')
var npm = 'npm'
exec(npm + ' i', function (er, stdout, stderr) {
if (er) {
process.stdout.write(stdout)
Expand Down
2 changes: 1 addition & 1 deletion problems/07-publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports.verify = function (args, cb) {
var pkg = require(process.cwd() + '/package.json')
var name = pkg.name
var exec = require('child_process').exec
var npm = require('which').sync('npm')
var npm = 'npm'
exec(npm + ' --color=always view ' + name, function (er, stdout, stderr) {
if (er) {
process.stderr.write(stderr)
Expand Down