Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update problems to use const and let #662

Closed
wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Mar 16, 2019

resolve #660

'var' is used in some problem.md files. I think 'let' or 'const' should be used instead of 'var'.

@shisama
Copy link
Contributor Author

shisama commented Apr 21, 2019

Is there anybody who can review this?

@shisama
Copy link
Contributor Author

shisama commented Aug 28, 2019

@AnshulMalik Hi, I created this PR 5 months ago. Please review this PR and merge it when you have time. Thanks.

@AnshulMalik
Copy link
Contributor

Hi @shisama, sorry it went unnoticed for so long. Probably because of so many file changes together. I am so sorry for not having a look at it.
I think the exercises are already converted by community.

@shisama
Copy link
Contributor Author

shisama commented Aug 29, 2019

@AnshulMalik Thank you for your reply.

Probably because of so many file changes together.

Is it better for you to divide this PR each exercise? For example, one is PR to update exercises/http_collect, two is exercises/http_file_server, ...

I think the exercises are already converted by community.

OK, I will change the latest code again.

@AnshulMalik
Copy link
Contributor

Yes @shisama one PR per exercise is generally best. Moreover not many exercises are left now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update problems to use const and let
3 participants