Check for unclosed lock in read-dbs #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2016
syzer
reviewed
Dec 29, 2016
| var dinosaurs = db.sublevel('dinosaurs') | ||
|
|
||
| ;[robots, dinosaurs].map(function (lev, i) { | ||
| lev.put('slogan', 1 === i ? 'rawr' : 'beep boop'); |
There was a problem hiding this comment.
; is required since the rest of the file has no ;'s 😄
syzer
reviewed
Dec 29, 2016
| } | ||
| var result = {} | ||
| var stream = db.readStream() | ||
| var error |
There was a problem hiding this comment.
should not declarations do on top of scope?
syzer
reviewed
Dec 29, 2016
| callback(error || err, result) | ||
| level(dir, { valueEncoding: valueEncoding }, function (err, db) { | ||
| if (err) { | ||
| if ( err.type === 'OpenError') { |
…veldb are still compiled
martinheidegger
force-pushed
the
fix/42
branch
from
c82aac6
to
31b9f21
Compare
|
Waiting for #95 to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the solution doesn't close the database a unclear error is printed. This PR adds the same error display that is used in other parts of the workshopper also when reading the database for a comparsion.
This PR fixes #42.