Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintained? #182

Closed
martinheidegger opened this issue Aug 20, 2016 · 17 comments
Closed

Maintained? #182

martinheidegger opened this issue Aug 20, 2016 · 17 comments

Comments

@martinheidegger
Copy link
Collaborator

Hello @substack,

I am trying to improve the workshoppers that are presented in NodeSchool and I am seeing a lot of PR's and issues in stream-adventure. stream-adventure is one of the most interesting tutorials of NodeSchool and I am wondering if you need help with maintaining it?

@BerniceChua
Copy link

Hi @substack & @martinheidegger, that's a great idea. At this time, I'm still trying to learn, so I can't tell if the tests aren't passing because I did something wrong, or because of a bug in the test itself.

I would like to help maintain this too, but in order for me to do that, what resources do you recommend for me to use? Thanks in advance.

@kalinchernev
Copy link
Member

I also hit the wall early on and got frustrated with simple things not working, so I came to notice the number of issues and pull requests.

@substack would it help if I you have at least someone to make review on these requests and issues and label them? (i.e. having someone to help without merging)

@martinheidegger
Copy link
Collaborator Author

@kalinchernev stream-adventure now moved to the workshopper organization.
I am very busy with some other task at the workshopper org atm. but my next task is definitely to update other out-dated workshoppers (such as this one). You can speed this up by joining the org (to which i just invited you!)

@kalinchernev
Copy link
Member

Hi @martinheidegger thanks for the invite!
I can now go through the issue queue and "triage" when I can to help in the process.
Is there any convention for the labelling I should follow on the way?

@martinheidegger
Copy link
Collaborator Author

@kalinchernev Not at the moment. Please triage at free will.

@hirejohnsalcedo
Copy link

@martinheidegger @kalinchernev I am also interested in helping the development and maintenance of these tutorials. May I have instructions on where am I needed, or what I need to do?

@martinheidegger
Copy link
Collaborator Author

@jpls93 There is no one in charge of coordinating this effort (yet?) What do you think should be tackled first? (My next task on the list would be to move from adventure to workshopper-adventure)

@kalinchernev
Copy link
Member

kalinchernev commented Mar 18, 2017

Hi,
I also don't know if anyone is in charge. After spending some time with the repo, things are not as bad as they seem on first sight.

Shortly, the situation is more or less as following:

There are also few new issues which are not categorized yet, so the same triaging can be applied to them. I think there are tasks for anyone interested into contributing, like answering questions and adding some guidelines. (I personally opened few pull requests adding guidelines for things that were problematic for me and I found suggested by issues)

Most importantly, I think, the non-stale pull request could be merged or given feedback to, in order to handle the issues which are already solved.

About migrating to workshopper-adventure, I am interested into working on this. If I know a potential pull request would be reviewed, it'd be also a good learning contribution.

@martinheidegger
Copy link
Collaborator Author

Hi @kalinchernev I made you team maintainer for the time being of stream-adventure-leads team. 😉 I don't think I ever tried to update stream-adventure to workshopper-adventure but i found an fr fork https://github.com/deliciousinsights/stream-adventure/tree/l10n-fr (if that helps)

@kalinchernev
Copy link
Member

@martinheidegger thanks, I'm honored! :)
The fork could be a good base for having the first translation. #161 is also related to this.
@jpls93 what would you be interested into?

@kalinchernev
Copy link
Member

@martinheidegger I started merging the low-hanging fruits which include clarifications in the problems' definitions. I think it'd be a good idea to make a release to npm after this.
What is the procedure for publishing releases?

@hirejohnsalcedo
Copy link

hirejohnsalcedo commented Mar 19, 2017

@kalinchernev @martinheidegger

Hello. I'm sorry I'm only speaking from a beginner's point of view. I'm not sure if my points are valid.

I understand that one of the challenges in developing these workshops is the level of knowledge to assume on a user who will be installing and going through the workshops. Forgive me if my position is weak since I'm only basing on introspection. It just makes me think that these workshops are created at all, to focus on beginners' user experience.

For example, in stream-adventure, I found it intimidating to have the workshop assume that I know about importing modules (e.g. fs), or what process.argv[2] is. I know that diligence on a user would eventually lead to the docs, or even these links should they find the installation process bewildering.

I am not sure how to efficiently tackle the challenge I have raised above. So, I decided to just start the process of developing a personal website to write articles/tutorials which would attempt to address them.

Thanks!

@kalinchernev
Copy link
Member

Hi @jpls93 I personally think that "beginner" point of view, as you say, is a useful thing. I also still find many of the challenges intimidating as I'm coming from the PHP world where I've never seen or used streams before. So, similarly as you I went through the issue queue and pull requests while working on the adventure itself. (And I also jotted some thoughts in the process)

Contributing is much more than writing sophisticated code on github etc ;)

If you're interested, you can be helpful with things like:

  • going through the list of pull requests and giving a thumbs up or feedback about things suggested. For example, i have opened few pull requests myself and it'd be really helpful for a second person to have a saying there
  • you can also work through the issue queue: both creating new items for feeback you feel after making the challenges and replying to questions you know the answer to

At any case, I encourage you to give feedback and suggestions while you're making the challenges, as this is the best way to relate to the communication around the repo.

@martinheidegger
Copy link
Collaborator Author

What is the procedure for publishing releases?

  1. You need permissions to publish the workshopper. @workshopper/deploy should have permission but it seems like that has not been given yet. @julianduque Would you mind to give @kalinchernev access to the repo?
  2. There is no org-wide release policy (we could setup a recommendation doc?!). However I try to have signed commits and use standard-version but that is my personal preference.

@kalinchernev
Copy link
Member

@martinheidegger thanks, I see the topic is more global so I'll place some comments in the main thread of the @workshopper/deploy

@julianduque
Copy link
Collaborator

I gave write permissions to @kalinchernev on this repo

@ccarruitero
Copy link
Contributor

This thread is outdated, and was resolved in that time. Closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants