Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could you provide a way to localize ? #161

Closed
pretty00butt opened this issue Oct 28, 2015 · 6 comments
Closed

could you provide a way to localize ? #161

pretty00butt opened this issue Oct 28, 2015 · 6 comments

Comments

@pretty00butt
Copy link

Hi, I'm hoony from Korea.

Could you let me know how to localize this project like i18n?

@kalinchernev
Copy link
Member

Hi @6thmonth I think it'd definitely possible after some refactoring of the core framework of the workshopper.

I googled a bit on the subject and found that discussion around i18n which lead me to see that there is a new framework workshopper-adventure, which provides the means to make the workshopper translatable. For example, I opened the main file of the learnyounode workshopper which integrates the workshopper-adventure framework.

I'd treat this issue as a feature request, which would lead to refactoring of the main module to depend on the new workshopper-adventure framework. Then the translations will be possible via normal pull requests giving translation files.

CC @martinheidegger

@pretty00butt
Copy link
Author

that's great news :) I'll looking forward to do that, thanks!

best

hoony

const me = {

  “name_en”: “Hoony Chang”,

  “name_kr”: “춘식”,

  “type”: ["civic hacker”, “freelancer”],

  “language”: [“javascript”],

  “sports”: [“basketball”],

  “contact”: {

    “email_private”: “6thmonth@protonmail.ch”,

    “email_public”: “hoonch3@gmail.com”,

    “github”: “@6thmonth”,

    “twitter”: “@6thmonth__"

  }

}

On Sun, 06 Nov 2016 at 01:06 Kalin Chernev

<
mailto:Kalin Chernev notifications@github.com

wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }

Hi
https://github.com/6thmonth
I think it'd definitely possible after some refactoring of the core framework of the workshopper.

I googled a bit on the subject and found that
nodeschool/organizers#64
which lead me to see that there is a new framework
https://github.com/workshopper/workshopper-adventure
, which provides the means to make the workshopper translatable. For example, I opened
https://github.com/workshopper/learnyounode/blob/master/learnyounode.js
workshopper which integrates the workshopper-adventure framework.

I'd treat this issue as a feature request, which would lead to refactoring of the main module to depend on the new workshopper-adventure framework. Then the translations will be possible via normal pull requests giving translation files.

CC
https://github.com/martinheidegger

You are receiving this because you were mentioned.

Reply to this email directly,
#161 (comment)
, or
https://github.com/notifications/unsubscribe-auth/ABTYka3nipWRPsEt-LVNeQvkQXFHfnULks5q7KmOgaJpZM4GXYAn
.

@ghost
Copy link

ghost commented Nov 6, 2016

I don't think it's necessary to port to workshopper-adventure in order to do this, but it would be good to figure this out for adventure.

@kalinchernev
Copy link
Member

I just didn't find any other clue or documentation on the way :)
Should there be one, please share.

@martinheidegger
Copy link
Collaborator

@substack It was quite some work to properly translate workshoppers, including extensive work in regards to double-width characters and whatnot. In the interest of maintainability I would welcome if all workshoppers use workshopper-adventure (note: workshopper-adventure should be API compatible (if it isn't -> issue)

@kalinchernev kalinchernev self-assigned this Nov 6, 2016
@kalinchernev kalinchernev removed their assignment Dec 14, 2016
@ccarruitero
Copy link
Contributor

Closing this, since we are using now workshopper-adventure that come with i18n included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants