Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is master broken? #16

Closed
claudiopro opened this issue Nov 3, 2015 · 4 comments
Closed

Is master broken? #16

claudiopro opened this issue Nov 3, 2015 · 4 comments

Comments

@claudiopro
Copy link
Member

Hi @martinheidegger, is master broken? I ran the example foo adventure like this:

git clone git@github.com:workshopper/workshopper-adventure.git
cd workshopper-adventure
npm install
examples/foo.js
<nothing>
@claudiopro
Copy link
Member Author

The package version published on npm (v4.2.1) is also out of sync with package.json on master (v4.1.0), am I missing something? 😕

@tgfjt tgfjt closed this as completed in 177ce3d Nov 4, 2015
martinheidegger added a commit that referenced this issue Nov 4, 2015
add execute to fix #16 on example foo.js
@martinheidegger
Copy link
Contributor

It might be that you just accessed the repo while I was publishing the the code: The latest version is 4.2.2

Aside from that you are talking about a larger issue: The current documentation is out-of-sync and the current examples are not very good. If you look at learnyounode: It exports in learnyounode.js and then has a separate file bin/learnyounode for the binary that is reference respectively in the package.json main and bin.

@claudiopro
Copy link
Member Author

Ah! Gotcha. How can I help with documentation? From PR #17 I see the fix for v4.2.x is calling execute() on the return value of workshopper() i.e. the function exported by the workshopper-adventure module, is that right?

@martinheidegger
Copy link
Contributor

I have started to add issues to this repository with the labels "documentation" and "automization". maybe you could look at them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants