Menu breaks when opts.extra is not set #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out the master branch of makemehapi and found that selecting any of the menu options resulted in this error:
This could just be a bug in makemehapi, but since menu.js contained a different conditional at line 41 which checked for
opts.extras
before acting on it, I figured thatopts.extras
shouldn't be assumed.Feel free to close out if I'm wrong.