Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu breaks when opts.extra is not set #53

Merged
merged 1 commit into from
May 7, 2014

Conversation

linclark
Copy link
Contributor

@linclark linclark commented May 7, 2014

I was trying out the master branch of makemehapi and found that selecting any of the menu options resulted in this error:

/usr/local/lib/node_modules/makemehapi/node_modules/workshopper/menu.js:63
    if (opts.extras.indexOf(name.toLowerCase()) != -1)
                    ^
TypeError: Cannot call method 'indexOf' of undefined

This could just be a bug in makemehapi, but since menu.js contained a different conditional at line 41 which checked for opts.extras before acting on it, I figured that opts.extras shouldn't be assumed.

Feel free to close out if I'm wrong.

@rvagg
Copy link
Contributor

rvagg commented May 7, 2014

you're absolutely right @linclark, a late addition not properly tested. thanks for picking it up and the PR!

rvagg added a commit that referenced this pull request May 7, 2014
Menu breaks when opts.extra is not set
@rvagg rvagg merged commit 4cee9b1 into workshopper:master May 7, 2014
@linclark linclark deleted the menu-opts-extra branch May 7, 2014 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants