Skip to content

Commit

Permalink
Merge pull request #10 from worksome/bugfix/serialisation
Browse files Browse the repository at this point in the history
fix: resolve serialisation
  • Loading branch information
owenvoke committed Mar 22, 2024
2 parents f459d0b + 87c978a commit dfcd880
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 39 deletions.
28 changes: 0 additions & 28 deletions CHANGELOG.md

This file was deleted.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ composer test

## Changelog

Please see [CHANGELOG](CHANGELOG.md) for more information on what has changed recently.
Please see [GitHub Releases](https://github.com/worksome/graphql-helpers/releases) for more information on what has changed recently.

## Contributing

Expand Down
9 changes: 0 additions & 9 deletions RELEASE.md

This file was deleted.

2 changes: 1 addition & 1 deletion src/Definition/PhpEnumType.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function serialize($value): string
);
}

return $value->name;
return (new Convert($value->name))->toMacro();
}

public function parseValue($value)
Expand Down
16 changes: 16 additions & 0 deletions src/Testing/Concerns/HandlesEnumConversions.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

declare(strict_types=1);

namespace Worksome\GraphQLHelpers\Testing\Concerns;

use Jawira\CaseConverter\Convert;
use UnitEnum;

trait HandlesEnumConversions
{
public function enumToGraphQL(UnitEnum $enum): string
{
return (new Convert($enum->name))->toMacro();
}
}
3 changes: 3 additions & 0 deletions tests/PhpEnumTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ enum DummyIntEnum: int
'generates correct GQL name from enum cases',
function ($enumClass) {
$type = new PhpEnumType($enumClass);

expect($type->name)->toBe(class_basename($enumClass));

$names = Collection::make($type->getValues())
->map(fn(EnumValueDefinition $definition) => $definition->name)
->all();

expect($names)->toBe(
[
'PASCAL_CASE',
Expand Down Expand Up @@ -92,6 +94,7 @@ function ($enumClass) {
'extracts description from php attribute',
function ($enumClass) {
$type = new PhpEnumType($enumClass);

$descriptions = Collection::make($type->getValues())->map(
fn(EnumValueDefinition $definition) => $definition->description,
)->all();
Expand Down

0 comments on commit dfcd880

Please sign in to comment.