WIP to discuss with Owen

src/Definition/PhpEnumType.php

@@ -4,53 +4,57 @@
 
 namespace Worksome\GraphQLHelpers\Definition;
 
+use BackedEnum;
 use GraphQL\Error\SerializationError;
 use GraphQL\Type\Definition\Deprecated;
 use GraphQL\Type\Definition\Description;
 use GraphQL\Type\Definition\EnumType;
 use GraphQL\Utils\PhpDoc;
 use GraphQL\Utils\Utils;
-use Illuminate\Support\Str;
+use Illuminate\Support\Collection;
 use Jawira\CaseConverter\Convert;
+use ReflectionEnumBackedCase;
+use ReflectionEnumPureCase;
+use UnitEnum;
 
 /**
  * @phpstan-import-type PartialEnumValueConfig from EnumType
  */
 class PhpEnumType extends EnumType
 {
+
     public const MULTIPLE_DESCRIPTIONS_DISALLOWED = 'Using more than 1 Description attribute is not supported.';
     public const MULTIPLE_DEPRECATIONS_DISALLOWED = 'Using more than 1 Deprecated attribute is not supported.';
 
     /**
-     * @var class-string<\UnitEnum>
+     * @var class-string<BackedEnum>
      */
     protected string $enumClass;
 
     /**
-     * @param class-string<\UnitEnum> $enum
+     * @param  class-string<BackedEnum>  $enum
      */
     public function __construct(string $enum, string $name = null)
     {
         $this->enumClass = $enum;
         $reflection = new \ReflectionEnum($enum);
-
         /**
          * @var array<string, PartialEnumValueConfig> $enumDefinitions
          */
         $enumDefinitions = [];
         foreach ($reflection->getCases() as $case) {
             $enumDefinitions[(new Convert($case->name))->toMacro()] = [
-                'value' => $case->getValue(),
+                'value' => $case->getBackingValue(),
                 'description' => $this->extractDescription($case),
                 'deprecationReason' => $this->deprecationReason($case),
             ];
         }
 
         parent::__construct([
-            'name' => $name ?? $this->baseName($enum),
-            'values' => $enumDefinitions,
-            'description' => $this->extractDescription($reflection),
-        ]);
+                                'name' => $name ?? $this->baseName($enum),
+                                'values' => $enumDefinitions,
+                                'description' => $this->extractDescription($reflection),
+                            ]);
     }
 
     public function serialize($value): string

tests/PhpEnumTypeTest.php

@@ -0,0 +1,83 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Worksome\GraphQLHelpers\Tests;
+
+use GraphQL\Type\Definition\Description;
+use GraphQL\Type\Definition\EnumValueDefinition;
+use Illuminate\Support\Collection;
+use Worksome\GraphQLHelpers\Definition\PhpEnumType;
+
+/** @codingStandardsIgnoreStart */
+#[Description('Dummy enum description')]
+enum DummyEnum: string
+{
+
+    #[Description('PascalCase description')]
+    case PascalCase = 'pascal-case';
+    #[Description('SCREAMING_SNAKE_CASE description')]
+    case SCREAMING_SNAKE_CASE = 'screaming-snake-case';
+    #[Description('snake_case description')]
+    case snake_case = 'snake-case';
+}
+
+/** @codingStandardsIgnoreEnd */
+
+it(
+    'generates correct GQL name from enum cases',
+    function () {
+        $type = new PhpEnumType(DummyEnum::class);
+        expect($type->name)->toBe("DummyEnum");
+
+        $name = Collection::make($type->getValues())
+                            ->map(fn(EnumValueDefinition $definition) => $definition->name)
+                            ->all();
+        expect($name)->toBe(
+            [
+                'PASCAL_CASE',
+                'SCREAMING_SNAKE_CASE',
+                'SNAKE_CASE',
+            ],
+        );
+    },
+);
+
+it(
+    'generates correct GQL value from enum cases',
+    function () {
+        $type = new PhpEnumType(DummyEnum::class);
+
+        $values = Collection::make($type->getValues())
+                            ->map(fn(EnumValueDefinition $definition) => $definition->value)
+                            ->all();
+
+        expect($values)->toBe(
+            [
+                DummyEnum::PascalCase->value,
+                DummyEnum::SCREAMING_SNAKE_CASE->value,
+                DummyEnum::snake_case->value,
+            ],
+        );
+    },
+);
+
+it(
+    'extracts description from php attribute',
+    function () {
+        $type = new PhpEnumType(DummyEnum::class);
+
+        $descriptions = Collection::make($type->getValues())->map(
+            fn(EnumValueDefinition $definition) => $definition->description,
+        )->all();
+
+        expect($type->description)->toBe('Dummy enum description')
+            ->and($descriptions)->toBe(
+                [
+                    'PascalCase description',
+                    'SCREAMING_SNAKE_CASE description',
+                    'snake_case description',
+                ],
+            );
+    },
+);