Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles empty titles for short titles #218

Merged
merged 3 commits into from Jun 28, 2021
Merged

Handles empty titles for short titles #218

merged 3 commits into from Jun 28, 2021

Conversation

dalyIsaac
Copy link
Member

Current behaviour: Last raises InvalidOperationException when the Enumerable has length of 0.

Fixed behaviour: Last is only called when parts has a length > 0.

@dalyIsaac
Handles empty titles
cca2bf6 
`Last` raises `InvalidOperationException` when the `Enumerable` has length of 0.
@josteink
Copy link
Member

If this area is causing errors, I think maybe we should try isolating it in a function which we can easily add unit-tests for?

@dalyIsaac
Copy link
Member Author

Good idea - I'll do that

N1x0
N1x0 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@N1x0 N1x0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N1x0 N1x0 merged commit 95d4a6d into master Jun 28, 2021
@dalyIsaac dalyIsaac deleted the fix-short-title branch June 28, 2021 07:32
@dalyIsaac dalyIsaac added this to the 0.9.11 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josteink josteink josteink approved these changes

@N1x0 N1x0 N1x0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dalyIsaac @josteink @N1x0